Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unit test for cohere and handle stop curl #1856

Merged
merged 5 commits into from
Jan 15, 2025
Merged

Conversation

vansangpfiev
Copy link
Contributor

This pull request introduces several changes to the remote-engine component, focusing on enhancing the handling of streaming requests, improving status management, and adding new test cases. The most important changes include modifications to the StreamWriteCallback function, updates to the RemoteEngine::MakeStreamingChatCompletionRequest and RemoteEngine::HandleChatCompletion methods, and the addition of new test cases for the RemoteEngineTest suite.

Enhancements to streaming request handling:

Improved status management:

Template rendering improvements:

New test cases:

  • engine/test/components/test_remote_engine.cc: Added new test cases CohereRequest and CohereResponse to verify the correct handling of Cohere-specific requests and responses, including both streaming and non-streaming scenarios.## Describe Your Changes

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev changed the base branch from dev to main January 14, 2025 04:14
Copy link
Contributor

@nguyenhoangthuan99 nguyenhoangthuan99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vansangpfiev vansangpfiev merged commit ccece16 into main Jan 15, 2025
6 checks passed
@vansangpfiev vansangpfiev deleted the chore/cohere branch January 15, 2025 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants